HDDS-14219. Add metrics for ReadBlock#9753
Open
ss77892 wants to merge 3 commits intoapache:masterfrom
Open
Conversation
Contributor
Author
|
The failure is unrelated to the commits. |
yandrey321
reviewed
Feb 12, 2026
| .getContainerData(); | ||
| HddsVolume volume = containerData.getVolume(); | ||
| if (volume != null) { | ||
| volume.getVolumeIOStats().incReadTime(endTime - startTime); |
There was a problem hiding this comment.
can it be done in a single call? for each read we had to update all these metrics, there is no reason to do 3 separate calls
Contributor
Author
There was a problem hiding this comment.
Yep, added the helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
new metrics for recently added ReadBlock functionality.
Original patch was created by @rich7420
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14219
How was this patch tested?
Manually with HDDS-14453 applied.
The following dashboards were updated while read operations are performed:
Data read per Volume
Read Ops
Read Block Traffic
Total Read Block Traffic
Read Block Ops
Combined Chunk and Block Traffic