Skip to content

HDDS-14561. SCMRatisRequest/ResponseProto should use the shaded protobuf from Ratis #9733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szetszwo merged 11 commits into from
Feb 17, 2026
Merged

HDDS-14561. SCMRatisRequest/ResponseProto should use the shaded protobuf from Ratis #9733

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e87984a
HDDS-14561. SCMRatisRequest/ResponseProto should use the shaded proto…
Russole Feb 7, 2026
c0b3145
Fix checkstyle error
Russole Feb 7, 2026
4aa8930
Apply review feedback on protobuf handling
Russole Feb 10, 2026
eaa58a0
Merge branch 'master' into HDDS-14561
Russole Feb 11, 2026
8eeaa6e
Fix shaded protobuf mismatch in TestSCMRatisProtocolCompatibility test
Russole Feb 11, 2026
298f5de
Fix unit test error
Russole Feb 11, 2026
ac43a62
Refactor implementation and update CodecFactory
Russole Feb 13, 2026
2351cd1
Fix checkstyle error
Russole Feb 13, 2026
df9720b
Add ByteString handling support, adopt UnsafeByteOperations, and clea…
Russole Feb 14, 2026
b1955b1
Use UnsafeByteOperations to reduce unnecessary ByteString allocations
Russole Feb 14, 2026
d2702dd
Merge remote-tracking branch 'origin/master' into HDDS-14561
adoroszlai Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hadoop-hdds/interface-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
<includes>
<include>InterSCMProtocol.proto</include>
<include>SCMUpdateProtocol.proto</include>
<include>SCMRatisProtocol.proto</include>
</includes>
<outputDirectory>target/generated-sources/proto-java-for-ratis</outputDirectory>
<clearOutputDirectory>false</clearOutputDirectory>
Expand All @@ -101,6 +102,7 @@
<excludes>
<exclude>InterSCMProtocol.proto</exclude>
<exclude>SCMUpdateProtocol.proto</exclude>
<exclude>SCMRatisProtocol.proto</exclude>
</excludes>
<outputDirectory>target/generated-sources/proto-java-for-protobuf-${protobuf.version}</outputDirectory>
<clearOutputDirectory>false</clearOutputDirectory>
Expand Down
14 changes: 8 additions & 6 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
package org.apache.hadoop.hdds.scm.ha;

import com.google.common.base.Preconditions;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.TextFormat;
import java.util.ArrayList;
import java.util.List;
import org.apache.hadoop.hdds.protocol.proto.SCMRatisProtocol.Method;
Expand All @@ -29,6 +27,9 @@
import org.apache.hadoop.hdds.scm.ha.io.CodecFactory;
import org.apache.ratis.proto.RaftProtos.StateMachineLogEntryProto;
import org.apache.ratis.protocol.Message;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.TextFormat;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -111,9 +112,10 @@ public Message encode() throws InvalidProtocolBufferException {
}
methodBuilder.addAllArgs(args);
requestProtoBuilder.setMethod(methodBuilder.build());
final SCMRatisRequestProto requestProto = requestProtoBuilder.build();
return Message.valueOf(
org.apache.ratis.thirdparty.com.google.protobuf.ByteString.copyFrom(
requestProtoBuilder.build().toByteArray()));
UnsafeByteOperations.unsafeWrap(
requestProto.toByteString().asReadOnlyByteBuffer()));
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Russole , I see how this change works now -- it does prevent copying to an array but still needs type conversion from com.google.protobuf.ByteString to org.apache.ratis.thirdparty.com.google.protobuf.ByteString.

Let's fix also the conversion in this JIRA; see ContainerCommandRequestProto as an example for how to do it.

Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsafeWrap is not needed anymore.

    return Message.valueOf(requestProto.toByteString());

}

/**
Expand All @@ -122,7 +124,7 @@ public Message encode() throws InvalidProtocolBufferException {
public static SCMRatisRequest decode(Message message)
throws InvalidProtocolBufferException {
final SCMRatisRequestProto requestProto =
SCMRatisRequestProto.parseFrom(message.getContent().toByteArray());
SCMRatisRequestProto.parseFrom(message.getContent().asReadOnlyByteBuffer());

// proto2 required-equivalent checks
if (!requestProto.hasType()) {
Expand Down Expand Up @@ -173,7 +175,7 @@ public static String smProtoToString(StateMachineLogEntryProto proto) {
StringBuilder builder = new StringBuilder();
try {
builder.append(TextFormat.shortDebugString(
SCMRatisRequestProto.parseFrom(proto.getLogData().toByteArray())));
SCMRatisRequestProto.parseFrom(proto.getLogData().asReadOnlyByteBuffer())));
} catch (Throwable ex) {
LOG.error("smProtoToString failed", ex);
builder.append("smProtoToString failed with");
Expand Down
4 changes: 2 additions & 2 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisResponse.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@

package org.apache.hadoop.hdds.scm.ha;

import com.google.protobuf.InvalidProtocolBufferException;
import org.apache.hadoop.hdds.protocol.proto.SCMRatisProtocol.SCMRatisResponseProto;
import org.apache.hadoop.hdds.scm.ha.io.CodecFactory;
import org.apache.ratis.protocol.Message;
import org.apache.ratis.protocol.RaftClientReply;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;

/**
Expand Down Expand Up @@ -92,7 +92,7 @@ public static SCMRatisResponse decode(RaftClientReply reply)
return new SCMRatisResponse();
}

final SCMRatisResponseProto responseProto = SCMRatisResponseProto.parseFrom(response.toByteArray());
final SCMRatisResponseProto responseProto = SCMRatisResponseProto.parseFrom(response.asReadOnlyByteBuffer());

// proto2 required-equivalent checks
if (!responseProto.hasType()) {
Expand Down
6 changes: 3 additions & 3 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/BigIntegerCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.ProtoUtils;
import java.math.BigInteger;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;

/**
* Codec for type BigInteger.
Expand All @@ -29,7 +29,7 @@ public class BigIntegerCodec implements Codec {
@Override
public ByteString serialize(Object object) {
// BigInteger returns a new byte[].
return ProtoUtils.unsafeByteString(((BigInteger)object).toByteArray());
return UnsafeByteOperations.unsafeWrap(((BigInteger) object).toByteArray());
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/BooleanCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;

/**
* {@link Codec} for {@code Boolean} objects.
Expand Down
20 changes: 18 additions & 2 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/ByteStringCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;

/**
* A dummy codec that serializes a ByteString object to ByteString.
Expand All @@ -28,12 +28,28 @@ public class ByteStringCodec implements Codec {
@Override
public ByteString serialize(Object object)
throws InvalidProtocolBufferException {
if (object instanceof ByteString) {
return (ByteString) object;
}
if (object instanceof com.google.protobuf.ByteString) {
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to keep supporting com.google.protobuf.ByteString? Should everything used in SCM Codec have changed to org.apache.ratis.thirdparty.com.google.protobuf.ByteString after this PR?

com.google.protobuf.ByteString bs = (com.google.protobuf.ByteString) object;
return org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations
.unsafeWrap(bs.asReadOnlyByteBuffer());
}
return (ByteString) object;
}

@Override
public Object deserialize(Class<?> type, ByteString value)
throws InvalidProtocolBufferException {
if (type == ByteString.class || ByteString.class.isAssignableFrom(type)) {
return value;
}
if (type == com.google.protobuf.ByteString.class
|| com.google.protobuf.ByteString.class.isAssignableFrom(type)) {
return com.google.protobuf.UnsafeByteOperations
.unsafeWrap(value.asReadOnlyByteBuffer());
}
return value;
}
}
4 changes: 2 additions & 2 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/Codec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;

/**
* Codec interface to marshall/unmarshall data to/from {@link ByteString}.
Expand Down
7 changes: 4 additions & 3 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/CodecFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.Message;
import com.google.protobuf.ProtocolMessageEnum;
import java.math.BigInteger;
Expand All @@ -29,6 +27,7 @@
import java.util.Map;
import org.apache.commons.lang3.ClassUtils;
import org.apache.hadoop.hdds.security.symmetric.ManagedSecretKey;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;

/**
* Maps types to the corresponding {@link Codec} implementation.
Expand All @@ -47,7 +46,9 @@ public final class CodecFactory {
codecs.put(Boolean.class, new BooleanCodec());
codecs.put(BigInteger.class, new BigIntegerCodec());
codecs.put(X509Certificate.class, new X509CertificateCodec());
codecs.put(ByteString.class, new ByteStringCodec());
codecs.put(com.google.protobuf.ByteString.class, new ByteStringCodec());
codecs.put(org.apache.ratis.thirdparty.com.google.protobuf.ByteString.class,
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If com.google.protobuf.ByteString is still needed,

  • Add a new class, say ScmByteStringCodec, for org.apache.ratis.thirdparty.com.google.protobuf.ByteString.
  • import org.apache.ratis.thirdparty.com.google.protobuf.ByteString.
    codecs.put(com.google.protobuf.ByteString.class, new ByteStringCodec());
    codecs.put(ByteString.class, new ScmByteStringCodec());

If com.google.protobuf.ByteString is not needed, just remove it.

new ByteStringCodec());
codecs.put(ManagedSecretKey.class, new ManagedSecretKeyCodec());
}

Expand Down
9 changes: 4 additions & 5 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/EnumCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
package org.apache.hadoop.hdds.scm.ha.io;

import com.google.common.primitives.Ints;
import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.ProtoUtils;
import com.google.protobuf.ProtocolMessageEnum;
import java.lang.reflect.InvocationTargetException;
import org.apache.hadoop.hdds.scm.ha.ReflectionUtil;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;

/**
* {@link Codec} for {@link ProtocolMessageEnum} objects.
Expand All @@ -34,8 +34,7 @@ public class EnumCodec implements Codec {
public ByteString serialize(Object object)
throws InvalidProtocolBufferException {
// toByteArray returns a new array
return ProtoUtils.unsafeByteString(Ints.toByteArray(
((ProtocolMessageEnum) object).getNumber()));
return UnsafeByteOperations.unsafeWrap(Ints.toByteArray(((ProtocolMessageEnum) object).getNumber()));
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, filed HDDS-14623 for removing ProtoUtils.

}

@Override
Expand Down
46 changes: 32 additions & 14 deletions ...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/GeneratedMessageCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,34 +17,52 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.Message;
import java.lang.reflect.InvocationTargetException;
import java.nio.ByteBuffer;
import org.apache.hadoop.hdds.scm.ha.ReflectionUtil;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.Message;

/**
* {@link Codec} for {@link Message} objects.
*/
public class GeneratedMessageCodec implements Codec {

@Override
public ByteString serialize(Object object) {
return ((Message)object).toByteString();
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to support both com.google.protobuf.Message and org.apache.ratis.thirdparty.com.google.protobuf.Message?

If yes, use two GeneratedMessageCodec classes instead of using one class. Also, we need to put them to CodecFactory.

//CodecFactory
    codecs.put(com.google.protobuf.Message.class, new GeneratedMessageCodec());
    codecs.put(Message.class, new ScmGeneratedMessageCodec());

public ByteString serialize(Object object) throws InvalidProtocolBufferException {
try {
Object bs = ReflectionUtil
.getMethod(object.getClass(), "toByteString")
.invoke(object);
if (bs instanceof org.apache.ratis.thirdparty.com.google.protobuf.ByteString) {
return (org.apache.ratis.thirdparty.com.google.protobuf.ByteString) bs;
}
return org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations
.unsafeWrap(((com.google.protobuf.ByteString) bs).asReadOnlyByteBuffer());

} catch (Exception e) {
throw new InvalidProtocolBufferException(
"Message cannot be encoded: " + e.getMessage());
}
}

@Override
public Message deserialize(Class<?> type, ByteString value)
public Object deserialize(Class<?> type, ByteString value)
throws InvalidProtocolBufferException {
try {
return (Message) ReflectionUtil.getMethod(type,
"parseFrom", byte[].class)
.invoke(null, (Object) value.toByteArray());
} catch (NoSuchMethodException | IllegalAccessException
| InvocationTargetException ex) {
ex.printStackTrace();
try {
return ReflectionUtil
.getMethod(type, "parseFrom", ByteBuffer.class)
.invoke(null, value.asReadOnlyByteBuffer());
} catch (NoSuchMethodException ignored) {
// fallback：parseFrom(byte[])
return ReflectionUtil
.getMethod(type, "parseFrom", byte[].class)
.invoke(null, value.toByteArray());
}
} catch (Exception e) {
throw new InvalidProtocolBufferException(
"Message cannot be decoded: " + ex.getMessage());
"Message cannot be decoded: " + e.getMessage());
}
}
}
8 changes: 4 additions & 4 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/IntegerCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
package org.apache.hadoop.hdds.scm.ha.io;

import com.google.common.primitives.Ints;
import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.ProtoUtils;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;

/**
* Encodes/decodes an integer to a byte string.
Expand All @@ -30,7 +30,7 @@ public class IntegerCodec implements Codec {
public ByteString serialize(Object object)
throws InvalidProtocolBufferException {
// toByteArray returns a new array
return ProtoUtils.unsafeByteString(Ints.toByteArray((Integer) object));
return UnsafeByteOperations.unsafeWrap(Ints.toByteArray((Integer) object));
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/ListCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import java.lang.reflect.InvocationTargetException;
import java.util.ArrayList;
import java.util.List;
import org.apache.hadoop.hdds.protocol.proto.SCMRatisProtocol.ListArgument;
import org.apache.hadoop.hdds.scm.ha.ReflectionUtil;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;

/**
* {@link Codec} for {@link List} objects.
Expand Down
8 changes: 4 additions & 4 deletions hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/LongCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
package org.apache.hadoop.hdds.scm.ha.io;

import com.google.common.primitives.Longs;
import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import com.google.protobuf.ProtoUtils;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;

/**
* {@link Codec} for {@code Long} objects.
Expand All @@ -31,7 +31,7 @@ public class LongCodec implements Codec {
public ByteString serialize(Object object)
throws InvalidProtocolBufferException {
// toByteArray returns a new array
return ProtoUtils.unsafeByteString(Longs.toByteArray((Long) object));
return UnsafeByteOperations.unsafeWrap(Longs.toByteArray((Long) object));
}

@Override
Expand Down
20 changes: 14 additions & 6 deletions ...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/ManagedSecretKeyCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@

package org.apache.hadoop.hdds.scm.ha.io;

import com.google.protobuf.ByteString;
import com.google.protobuf.InvalidProtocolBufferException;
import org.apache.hadoop.hdds.protocol.proto.SCMSecretKeyProtocolProtos;
import org.apache.hadoop.hdds.security.symmetric.ManagedSecretKey;
import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
import org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException;
import org.apache.ratis.thirdparty.com.google.protobuf.UnsafeByteOperations;

/**
* A codec for {@link ManagedSecretKey} objects.
Expand All @@ -30,14 +31,21 @@ public class ManagedSecretKeyCodec implements Codec {
public ByteString serialize(Object object)
throws InvalidProtocolBufferException {
ManagedSecretKey secretKey = (ManagedSecretKey) object;
return secretKey.toProtobuf().toByteString();
return UnsafeByteOperations.unsafeWrap(
secretKey.toProtobuf().toByteString().asReadOnlyByteBuffer());
}

@Override
public Object deserialize(Class<?> type, ByteString value)
throws InvalidProtocolBufferException {
SCMSecretKeyProtocolProtos.ManagedSecretKey message =
SCMSecretKeyProtocolProtos.ManagedSecretKey.parseFrom(value);
return ManagedSecretKey.fromProtobuf(message);
try {
SCMSecretKeyProtocolProtos.ManagedSecretKey message =
SCMSecretKeyProtocolProtos.ManagedSecretKey.parseFrom(
value.asReadOnlyByteBuffer());
return ManagedSecretKey.fromProtobuf(message);
} catch (com.google.protobuf.InvalidProtocolBufferException e) {
throw new org.apache.ratis.thirdparty.com.google.protobuf.InvalidProtocolBufferException(
e.getMessage());
Copy link
Copy Markdown
Contributor

@szetszwo szetszwo Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include the type in the message and use e as the cause (it will keep e's stack trace.)

      throw new InvalidProtocolBufferException("Failed to deserialize value for " + type, e);

}
}
}
Loading
Loading