HDDS-16506. Consistent DurationSeconds Validation Message and Minor Design Doc and comment updates - #11261
Open
fmorg-git wants to merge 6 commits into
Open
HDDS-16506. Consistent DurationSeconds Validation Message and Minor Design Doc and comment updates#11261fmorg-git wants to merge 6 commits into
fmorg-git wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe your PR in detail:
4320010, it saysInvalid Value: DurationSeconds must be between 900 and 43200 seconds. However is the value is invalid and overflows an integer type like43200100000, it saysInvalid Value: DurationSeconds must be a number. The latter message is shown also in the case of a non-numeric invalid value likeabcbut it is confusing for numeric overflow values.This ticket will make the validation message consistent for all cases.Separately, this ticket updates the STS design doc with minor changes and makes a minor update to a comment in
S3STSConfigKeys.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16506
How was this patch tested?
smoke tests, manual testing