Conversation
…on the stream Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chihsuan
approved these changes
Sep 17, 2026
|
|
||
| /** A request rejected on the stream ends the call from the datanode side, so the block file must be closed there. */ | ||
| @Test | ||
| public void testReadBlockErrorOnTheStreamClosesTheBlockFile() throws Exception { |
Contributor
There was a problem hiding this comment.
nit: Would it be worth adding a successful read before the out-of-range request? It helps confirm that an already-open file is being closed on the same stream.
Contributor
Author
There was a problem hiding this comment.
@chihsuan Thank you for looking into it! I've added a successful read to the test.
…request in the stream test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
readBlockImpl reports an out of range offset with StreamObserver.onError, which ends the call from the datanode side. GrpcXceiverService closes the stream's RandomAccessFileChannel only when the client completes the stream or a request throws, so the block file stayed open. rejectReadBlock closes it before reporting the error.
Improvements to TestKeyValueHandler. Replace the readBlock helper with a StreamFixture for multi-request ReadBlock tests. The old helper wrote one zero-filled block, sent one request and closed the block file, so a test could neither send several requests on one stream nor check the state of the stream's block file. StreamFixture keeps the container, block and RandomAccessFileChannel for the test's lifetime, appends chunks whose bytes encode their position, and assertResponses checks the streamed data against that. No test behavior changes. Those changes would be required for several followups including HDDS-16377
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16421
How was this patch tested?
UTs
freon/warp workloads