HDDS-15781. Adding Spankind information to ozone sh commands#10695
HDDS-15781. Adding Spankind information to ozone sh commands#10695sravani-revuri wants to merge 4 commits into
Conversation
|
@sumitagrawl , could you please review these changes. |
chihsuan
left a comment
chihsuan
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri, this looks good.
Left a couple of small inline notes. As a non-committer these are just suggestions. Sill need to wait a committer to review and approve before merge. Thanks for the clear screenshots too. 🙂
|
|
||
| try (TracingUtil.TraceCloseable ignored = TracingUtil.createActivatedSpan(name + "." + method.getName())) { | ||
| // close() is local cleanup in the shell process, not an outbound RPC to OM/SCM/DN , so it stays INTERNAL. | ||
| SpanKind spanKind = "close".equals(method.getName()) |
There was a problem hiding this comment.
Thanks for adding the comment. @sravani-revuri Just thinking a bit more on this, is close the only local method here?
It looks like getS3CredentialsProvider() just returns a ThreadLocal with no RPC, yet it'd still read as CLIENT. Should we avoid inferring the span kind from the method name here? Would a method-level override/annotation for local operations be more robust while keeping remote protocol methods CLIENT by default? curious what you think.
2 participants
What changes were proposed in this pull request?
Adding spankind information for all traces as a part of ozone sh commands. The are given the information of:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15781
How was this patch tested?
Manual test of all ozone sh commands.
Few outputs:
volume create:
key put command: