arch/tricore: drop iLLD dependency in hwdebug - #19836
Open
zyfeier wants to merge 1 commit into
Open
Conversation
Remove the dependency on the iLLD SFR headers (IfxCpu_bf.h and IfxCbs_reg.h) and the iLLD intrinsics (__mfcr/__mtcr) from the hardware debug monitor implementation. The debug CSFR numbers, trigger-event register (TR0..TR7) addresses, TREVT bit-field offsets and the CBS_OEC register address are now defined locally with a TC_ prefix, so the file no longer leaks the iLLD CPU_* namespace (which is still pulled in transitively through arch/irq.h). Register accesses use the tricore_mfcr/tricore_mtcr macros, and the DBGTCR/DBGCFG/DBGACT bit-field unions are replaced with explicit shifts. This is a pure de-iLLD refactor with no behavior change, verified on a TC4x7 EVB: the board boots to NuttShell and breakpoints trigger identically before and after the change. Change-Id: I11b9b8ca1f3d3b7b32907592f2b992b025035c5c
github-actions
Bot
added
Arch: tricore
|
xiaoxiang781216
approved these changes
Aug 13, 2026
Contributor
|
@zyfeier please fix: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the iLLD dependency from the TriCore hardware debug monitor
(
tricore_hwdebug.c), continuing the de-iLLD effort forarch/tricore.The debug CSFR numbers, trigger-event register (TR0..TR7) addresses,
TREVT bit-field offsets and the CBS_OEC register address are now defined
locally with a
TC_prefix, so the file no longer depends on the iLLDSFR headers (
IfxCpu_bf.h,IfxCbs_reg.h) nor the iLLD intrinsics(
__mfcr/__mtcr). Register accesses use thetricore_mfcr/tricore_mtcrmacros, and theDBGTCR/DBGCFG/DBGACTbit-fieldunions are replaced with explicit shifts.
The
TC_prefix avoids a redefinition clash with the iLLDCPU_*namespace, which is still pulled in transitively through
arch/irq.h.Impact
Behavior is unchanged; this is a pure de-iLLD refactor.
Testing
triboard_tc4x9_com:nsh(TC1V8) anda2g-tc397-5v-tft:nsh(TC1V6) both compile with 0 errors and no redefinition warnings.
checkpatch.sh: pass.debugpointtest app confirmsbreakpoints trigger identically before and after the change. Verified
on real hardware that the watchpoint trigger itself fires at the
correct faulting PC (any watchpoint-callback discrepancy in the test
app is pre-existing and unrelated to this change).