Repository navigation
testing/ostest: Restore the round-robin test defaults. - #3832
Merged
Merged
Conversation
This reverts commit 27ecdd7. rr_test records which thread finishes each run, and fails if the first CONFIG_TESTING_OSTEST_RR_RUNS runs all come from one thread. With 4 runs over a range of 10000, one thread on qemu-armv8a does all its runs within one time slice, before the other thread finishes a run, and the test stops with an assertion at roundrobin.c:281. Since that change, ostest crashes on every qemu-armv8a configuration that CI tests (arm64-01). Restore 30000 and 10 runs. A slow board can set CONFIG_TESTING_OSTEST_RR_RANGE and CONFIG_TESTING_OSTEST_RR_RUNS lower in its defconfig. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
cederom
approved these changes
Oct 11, 2026
1 task done
cederom
requested review from
acassis,
raiden00pl,
simbit18 and
xiaoxiang781216
October 11, 2026 10:43
Contributor
|
Can confirm this also fixes the exact same rr_test: Roundrobin Failed failure on Linux (risc-v-05) (rv-virt64:citest64), which also uses CONFIG_RR_INTERVAL=200 |
raiden00pl
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #3809,
osteststops with an assertion inrr_teston qemu-armv8a, and theLinux (arm64-01)CI job fails for every nuttx PR:rr_testrecords which thread finishes each run, and fails if the firstCONFIG_TESTING_OSTEST_RR_RUNSruns all come from one thread. With 4 runs over a range of 10000, one thread does all its runs within one time slice (CONFIG_RR_INTERVAL=200), before the other thread finishes a run.This PR reverts #3809: the defaults go back to a range of 30000 and 10 runs. A slow board can set
CONFIG_TESTING_OSTEST_RR_RANGEandCONFIG_TESTING_OSTEST_RR_RUNSlower in its defconfig.Impact
ostesttakes longer again on slow targets that use the defaults.Testing
nuttx master (284d4d4ea4d), QEMU 11,
ostest:qemu-armv8a:citestqemu-armv8a:citest_smp(-smp 4)rr_testfails, exit status 256rr_testfails, exit status 256rr_test: Done, exit status 0 (2 of 2 runs)rr_test: Done, exit status 0 (2 of 2 runs)tools/checkpatch.sh -c -u -m -gpasses.