Repository navigation
Conversation
Add the blank line after the declarations in main(). No code change. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
netcat_main.c uses errno and true, and nxinit/parser.c uses errno and the error codes, but neither file includes errno.h, and netcat_main.c does not include stdbool.h. They compile only because other headers include them indirectly. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
cederom
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
netutils/netcat/netcat_main.cuseserrnoandtrue, andsystem/nxinit/parser.cuseserrno,E2BIG,EINTRandEINVAL. Neither file includeserrno.h, andnetcat_main.cdoes not includestdbool.h. They compile only becausestdio.hincludes them indirectly. This PR adds the includes.The first commit adds a blank line in
netcat_main.cto fix its old nxstyle error. It does not change code.Impact
None. The two files include what they use.
Testing
Builds with
-Wno-cpp -Werrorand astdio.hthat does not includenuttx/fs/fs.handnuttx/lib/lib.h(see apache/nuttx#20565):lm3s6965-ek:qemu-flatnetcat_main.crv-virt:nsh64nxinit/parser.ctools/checkpatch.sh -c -u -m -gpasses.