Repository navigation
Conversation
4 of 5 tasks
cederom
previously requested changes
Oct 11, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @anatol please update PR description according to https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md :-)
Author
|
@cederom Thank you for the feedback. PTAL. |
Add a host-side regression program under testing/libc/fmaf that compiles the NuttX fmaf implementation and compares results and required exception flags with host libm across all four rounding modes. Include Make and CMake metadata for building it as a NuttX test app. Keep the comparison harness with the apps testing sources rather than the NuttX tools directory, and document how to invoke it from nuttx-apps. Tests: host C compiler build and run against system libm; 4,072,672 cases passed across four rounding modes. Assisted-by: Claude Code:claude-sonnet-5-5 Signed-off-by: Anatol Pomozov <anatol@google.com>
xiaoxiang781216
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testing/fmafthat compares NuttXfmaf()with the hostlibm.fmaf()behavior against hostlibm.Impact
fmaf()regression program.lib_fmaf.cimplementation and hostlibm. It is a companion for libs/libm: Add fmaf, using fmadd.s on RISC-V targets with an FPU. nuttx#20553Testing
PR verification Self-Check
☑ This PR introduces only one functional change.
☑ I have updated all required description fields above.
☑ My PR adheres to the Contributing Guidelines and Documentation.
☐ My PR is still work in progress (not ready for review).
☑ My PR is ready for review and can be safely merged into a codebase.
Assisted-by: Claude Code:claude-sonnet-5-5