testing/ostest: multiuser coverage for supplementary groups and setresuid - #3714
Merged
acassis merged 2 commits intoAug 14, 2026
Merged
Conversation
acassis
requested review from
cederom,
linguini1,
raiden00pl,
xiaoxiang781216 and
yf13
August 10, 2026 19:13
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 12, 2026 06:40
9b7be97 to
6c7b378
Compare
xiaoxiang781216
previously approved these changes
Aug 12, 2026
Contributor
|
@Abhishekmishra2808 please fix ci warning and pr title/description |
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 12, 2026 07:05
6c7b378 to
4cf5292
Compare
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
2 times, most recently
from
August 12, 2026 18:52
fbe1485 to
b07c609
Compare
Contributor
|
Please add a log of your additional OSTest suite passing. |
Add supplementary-group, setresuid/setresgid ordering, and saved set-UID/GID child tests for the POSIX credential APIs. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
When NSH_PROMPT_STRING_ROOT/USER are empty, keep NSH_PROMPT_STRING at boot (for example, "nsh> ") so CI/NTFC boot detection still works. After login, su, or telnet login, replace the last '>' with '#' (euid 0) or '$' (non-zero euid) and ensure a trailing space. Refresh readline after console/telnet login when line editing is enabled. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
force-pushed
the
feature/supp-groups-and-sudo
branch
from
August 13, 2026 21:00
b07c609 to
c67b8bc
Compare
xiaoxiang781216
approved these changes
Aug 14, 2026
Contributor
Author
|
@linguini1 PTAL at the updated testing logs |
acassis
approved these changes
Aug 14, 2026
Member
|
@acassis why this was merged ? CI is now broken ... |
Contributor
|
The test logs don't even show the multi user test, they show a scheduler lock test. @Abhishekmishra2808 |
Contributor
The issue was not related to this PR |
Member
Contributor
|
@raiden00pl yes, I only saw the issue with toybox defconfig, but that was because it was not normalized |
Member
|
c67b8bc has broken NTFC and it is visible in CI for this PR: https://github.com/apache/nuttx-apps/actions/runs/31743634370/job/94593362401 |
Member
|
@acassis this is probably the reason #3690 (comment) CI for apps is broken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
This change only extends testing/ostest/multiuser.c to exercise the new kernel credential APIs. It adds coverage for supplementary groups, setresuid/setresgid drop ordering, getresuid/setreuid, and saved set-UID/GID behavior in a child task. Builds without
CONFIG_SCHED_USER_IDENTITYare unchanged.Testing