Application.mk: Add missing preconfig target#3386
Closed
ThePassionate wants to merge 1 commit intoapache:masterfrom
Closed
Application.mk: Add missing preconfig target#3386ThePassionate wants to merge 1 commit intoapache:masterfrom
ThePassionate wants to merge 1 commit intoapache:masterfrom
Conversation
When running 'make preconfig' from the apps directory (e.g. to regenerate Kconfig files with absolute paths), the build fails in subdirectories that include Application.mk but do not define a preconfig target (e.g., apps/modbus, apps/nshlib). This commit adds a dummy preconfig target to Application.mk to ensure the recursive make successfully traverses these directories. Signed-off-by: makejian <makejian@xiaomi.com>
ThePassionate
force-pushed
the
fix/preconfig
branch
from
3accf52 to
f695aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a default
preconfigtarget toApplication.mk. This ensures that themake preconfigcommand (used to generate/updateapps/Kconfigand sub-Kconfigs) can execute successfully across all subdirectories, even those that do not manage their ownKconfigfiles (e.g.,modbus,nshlib).Impact
This fix improves the robustness of the NuttX build system, specifically for environment reconfiguration scenarios. Without this fix, users cannot easily regenerate stale Kconfig files if their directory structure changes, as the recursive make process is blocked by subdirectories missing the
preconfigtarget.Testing
appsandnuttxdirectories to a new parent location, invalidating existing Kconfig absolute/relative paths.make preconfig TOPDIR=...inapps/failed with:make[1]: Entering directory '/path/to/apps/modbus' make[1]: *** No rule to make target 'preconfig'. Stop.make preconfigcompletes successfully. Theapps/Kconfigis correctly regenerated with valid absolute paths, restoring build functionality.