NIFI-15979 Add Connector reporting-task visibility#89
Merged
exceptionfactory merged 6 commits intoJun 2, 2026
Conversation
- ConnectorInitializationContext.setLoggingAttributes(Map): new default method (throws UOE) for connectors to surface custom MDC context. - AbstractConnector.setLoggingAttributes(Map): protected helper forwarding to the init context. - ProcessGroupStatus.loggingAttributes: snapshot map (default Map.of()) plus accessors; propagated through clone() and merge(). - EventAccess.getConnectorStatuses(): new default method returning an empty collection; implementations override to expose connector-managed Process Groups to reporting tasks. Pure API additions with default impls keep existing code compiling unchanged.
kevdoran
force-pushed
the
NIFI-15979-connector-logging
branch
from
ffd0870 to
ff83ed2
Compare
markap14
requested changes
May 27, 2026
Contributor
Author
|
Thanks for the review @markap14! I accepted all suggestions. |
markap14
reviewed
May 27, 2026
exceptionfactory
requested changes
May 30, 2026
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting this together @kevdoran. The changes look good for Connector Status. The addition of an open-ended way to set logging attributes is more concerning, and does not seem to align with the existing goal of framework-managed attributes. Instead of an open-ended Map of attributes, it seems better to extend the MDC set of attributes at the framework level, based on declared Connector properties.
| if (initializationContext == null) { | ||
| throw new IllegalStateException("Connector has not been initialized"); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This change appears unnecessary
| * @param attributes the custom attributes to expose on logs from this Connector and its managed flow; must not be {@code null} | ||
| * @throws UnsupportedOperationException if the runtime implementation does not support custom logging attributes | ||
| */ | ||
| default void setLoggingAttributes(Map<String, String> attributes) { |
Contributor
There was a problem hiding this comment.
This method is very open-ended, and moves in a different direction from the current framework-controlled Logging Attributes in a Process Group. Rather than exposing it as a point of extension, it seems better to maintain a strategy of declared properties, which the framework handles for inclusion.
The blank line between the null-check and the return statement in getInitializationContext() was inadvertently removed in an earlier revision of this branch and not restored when the surrounding helper method was dropped. Addresses review feedback on PR apache#89. Co-authored-by: Cursor <cursoragent@cursor.com>
kevdoran
changed the title
Per review feedback, remove the loggingAttributes snapshot field, its accessors, and the associated clone()/merge() plumbing from ProcessGroupStatus. The remaining ConnectorStatus type and EventAccess.getConnectorStatuses() provide connector identity to reporting consumers without adding a logging-attributes map to the Process Group status. Co-authored-by: Cursor <cursoragent@cursor.com>
exceptionfactory
approved these changes
Jun 2, 2026
markap14
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15979
These API changes relate to NIP-30
Pure API additions with default impls keep existing code compiling unchanged.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch