Prevent NPE in BuildClasspathMojo.appendArtifactPath() when an artifact has no resolved file#1623
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a null check for Artifact.getFile() in BuildClasspathMojo.appendArtifactPath() to prevent a potential NullPointerException when an artifact has no resolved file (e.g., system-scope or unresolved dependencies). Also renames the parameter art to artifact for clarity.
Changes:
- Add early-return null check on
artifact.getFile()with a warning log instead of dereferencing. - Rename parameter
art→artifactand remove the now-redundant@paramJavadoc tags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elharo
changed the title
elharo
changed the title
slawekjaranowski
approved these changes
May 17, 2026
elharo
changed the title
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1620