Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the potential NullPointerException reported in #1619 by making AbstractAnalyzeMojo.filterArtifactsByScope() null-safe when comparing artifact scopes.
Changes:
- Add
java.util.Objectsimport. - Replace
artifact.getScope().equals(scope)withObjects.equals(artifact.getScope(), scope)to prevent NPE whengetScope()isnull.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Can you update a title of PR - it will be add to release notes, so should be more descriptive |
elharo
changed the title
slawekjaranowski
approved these changes
May 17, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
Member
|
@elharo please look at release notes .... your PR are no categorized, also GitHub bot points you about it |
Member
|
Also commit should have similar - the best the same title as PR 😄 Do you look at git log ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1619