Allocate postings payload buffers only when the query requests them#16248
Open
slow-J wants to merge 1 commit into
Open
Allocate postings payload buffers only when the query requests them#16248slow-J wants to merge 1 commit into
slow-J wants to merge 1 commit into
Conversation
slow-J
force-pushed
the
payloadBufferAllocation
branch
from
099fe90 to
b8eac11
Compare
slow-J
force-pushed
the
payloadBufferAllocation
branch
from
b8eac11 to
486493b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
payloadLengthBuffer,payloadBytes,payloadare allocated whenindexHasPayloads, but are only read whenneedsPayloads. (AlsoneedsPayloadsdepends onindexHasPayloadsbeing true).Gating the allocation on
needsPayloadswould bring payloads to parity with the buffers inneedsOffsetsandneedsPos, saving some memory if the field stores payloads but the query does not request them.posDeltaBuffer[i] = code >>> 1had to be moved up a few lines so it is always called whenindexHasPayloads(this is already the current behaviour).Please let me know if I missed something.