Add Hangul composition char filter to analysis-nori#16242
Open
Incheonkirin wants to merge 1 commit into
Open
Conversation
rmuir
approved these changes
Jun 15, 2026
rmuir
left a comment
Member
There was a problem hiding this comment.
the use-case makes sense to me.
constants and formula matches directly with 3.12.3 Hangul Syllable Composition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16241
Summary
Add an opt-in HangulCompositionCharFilter to analysis-nori. The filter composes modern Hangul conjoining-jamo sequences into precomposed Hangul syllables before KoreanTokenizer, so NFD-form Korean text can analyze like the equivalent NFC text while preserving offset correction back to the original input.
The filter is intentionally narrow: it handles only modern L/V/optional-T conjoining jamo sequences and leaves compatibility jamo, archaic jamo, partial sequences, already-precomposed Korean text, and non-Hangul text unchanged. For general Unicode normalization the ICU module's ICUNormalizer2CharFilter remains the right tool; this covers the common Korean-only case without adding the ICU dependency to nori deployments.
Tests
Verification