KNOX-3276: Fix TLS version settings bug#1176
Merged
smolnar82 merged 1 commit intoapache:masterfrom Mar 13, 2026
Merged
Conversation
Test Results7 tests 7 ✅ 1s ⏱️ Results for commit 61982d1. |
hanicz
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3276: - Fixed a bug while setting SSL protocols
What changes were proposed in this pull request?
#1175 introduced new configuration to control CM client SSL configs. Unfortunately a bug sneaked in while configuring TLS protcols in
org.apache.knox.gateway.topology.discovery.cm.DiscoveryApiClient#configureSslProtocols: I used theconnectionSpecBuilder.cipherSuitesinstead ofconnectionSpecBuilder.tlsVersionsThis PR fixes that bug and extends existing unit tests to cover the SSL settings too.
How was this patch tested?
Extended and ran existing unit tests.
Integration Tests
N/A
UI changes
N/A