Use same spelling sampleResult in all dynamic samplers, functions, assertions and listeners#6369
Open
FSchumacher wants to merge 1 commit intoapache:masterfrom
Open
Use same spelling sampleResult in all dynamic samplers, functions, assertions and listeners#6369FSchumacher wants to merge 1 commit intoapache:masterfrom
FSchumacher wants to merge 1 commit intoapache:masterfrom
Conversation
…sertions and listeners
vlsi
approved these changes
Oct 25, 2024
Collaborator
vlsi
left a comment
There was a problem hiding this comment.
LGTM. However, I am afraid we have to support the old spelling for quite some time (e.g. 5+years) so we do not break users's scripts.
Contributor
Author
Yes, we will have to support both spellings for a long time. But I always dream, that we could deprecate and remove some stuff :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harmonize the spelling of the SampleResult variables used in scripting components.
Motivation and Context
In scripting listeners, assertions functions and samplers the SampleResult object is often given in the the scripting context via a variable. That variable should have the same name in all those components. This PR uses the spelling
sampleResultin favour ofSampleResult, as the variable points to an instance and in Java instances are named starting with a lowercase character.This issue has been described in #6368.
One could argue to use the old name
SampleResultas it might be found in more existing test cases.As the next version of JMeter will be a major version, we could use this to deprecate the old writing and remove those in a later major version.
How Has This Been Tested?
Test cases have been adapted to use the new and old spelling.
Screenshots (if appropriate):
Types of changes
Checklist: