Skip to content

Fix compaction test metadata lease cleanup#18172

Open
shuwenwei wants to merge 1 commit into
masterfrom
codex/fix-compaction-metadata-lease-teardown
Open

Fix compaction test metadata lease cleanup#18172
shuwenwei wants to merge 1 commit into
masterfrom
codex/fix-compaction-metadata-lease-teardown

Conversation

@shuwenwei

@shuwenwei shuwenwei commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Preserve the original metadata lease fence timeout in AbstractCompactionTest.
  • Restore the timeout and reset the metadata lease state during teardown.

Motivation

Compaction unit tests temporarily keep the metadata lease available to avoid fenced local metadata cache failures. Without symmetric teardown cleanup, the global lease timeout and lease state can leak across tests and cause unrelated failures.

@shuwenwei shuwenwei requested a review from HTHou July 9, 2026 09:37
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.04%. Comparing base (c716365) to head (a3c1cab).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #18172   +/-   ##
=========================================
  Coverage     42.04%   42.04%           
  Complexity      318      318           
=========================================
  Files          5312     5312           
  Lines        375102   375102           
  Branches      48422    48422           
=========================================
+ Hits         157693   157696    +3     
+ Misses       217409   217406    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant