feat(common): add deferred poll timeout support - #3948
Open
arunsingh wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3948 +/- ##
============================================
- Coverage 83.93% 83.73% -0.20%
Complexity 1358 1358
============================================
Files 1213 1214 +1
Lines 168441 168258 -183
Branches 135999 135941 -58
============================================
- Hits 141373 140884 -489
- Misses 23389 23557 +168
- Partials 3679 3817 +138
🚀 New features to boost your workflow:
|
Signed-off-by: Arun Singh <arunsingh.in@gmail.com>
Signed-off-by: Arun Singh <arunsingh.in@gmail.com>
arunsingh
force-pushed
the
feat/poll-messages-wait-timeout-ng
branch
from
August 24, 2026 11:10
a4486d1 to
d86e92b
Compare
arunsingh
marked this pull request as ready for review
August 24, 2026 11:44
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Closes #3470
Rationale
PollMessagesneeds a backward-compatible way for clients to request a bounded wait when no messages are available. Immediate polling remains unchanged for existing clients and for a zero timeout.What changed?
Empty
PollMessagesrequests can now carry a trailingwait_timeout_usfield; legacy requests decode it as zero, while partial trailing fields are rejected. The common, SDK, consumer-group, simulator, and HTTP-zero paths carry the value through the current tree.This is a clean rebuild after closed PR #3605. The active
core/serverpath currently rejects non-zero waits with typedFeatureUnavailableuntil a safe waiter/notifier implementation is designed. Nocore/server-ng, legacy server, benchmark markdown, or runbook files are included.Local Execution
cargo fmt --all— passedcargo clippy --all-targets --all-features -- -D warnings— passedcargo test -p iggy_binary_protocol poll_messages— 15 passedcargo test -p iggy_common wait_timeout— 2 passedcargo check -p iggy -p server -p simulator— passedcargo check -p integration --tests— passedcargo machete— passedcargo sort --workspace— passed; no changes neededtypos— passed./scripts/ci/license-headers.sh --check— passed with HawkEye 7git diff --check— passedprekis not installed in this environmentcargo build --workspacewas attempted but could not link in this x86_64-targeted macOS environment because the installed Homebrewxzandhwloclibraries are arm64. Full localcargo testis not claimed. Fresh GitHub CI run32720521140passed all 74 jobs after the rebase onto currentmaster.AI Usage
AI was used for code review, and test/CI orchestration. The changed code was reviewed and verified with the local checks above and GitHub CI; I can explain every line of the code if asked.