Skip to content

fix(shard): tell an unknown consensus operation from a corrupt header - #3931

Merged
hubcio merged 6 commits into
masterfrom
fix_version_fencing
Aug 24, 2026
Merged

fix(shard): tell an unknown consensus operation from a corrupt header#3931
hubcio merged 6 commits into
masterfrom
fix_version_fencing

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

Fixes given_an_unknown_operation_when_a_consensus_frame_decodes_should_surface_an_upgrade_fence_signal test.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.86792% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.88%. Comparing base (f8311d6) to head (4d27624).

Files with missing lines Patch % Lines
core/server_common/src/consensus_message.rs 90.00% 2 Missing and 8 partials ⚠️
core/shard/src/router.rs 84.21% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3931      +/-   ##
============================================
- Coverage     84.01%   83.88%   -0.13%     
  Complexity     1358     1358              
============================================
  Files          1214     1214              
  Lines        169851   169763      -88     
  Branches     137408   137537     +129     
============================================
- Hits         142703   142409     -294     
- Misses        23437    23504      +67     
- Partials       3711     3850     +139     
Components Coverage Δ
Rust Core 84.75% <93.86%> (-0.07%) ⬇️
Java SDK 66.67% <ø> (ø)
C# SDK 74.99% <ø> (-1.54%) ⬇️
Python SDK 90.13% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 95.90% <ø> (ø)
Go SDK 68.29% <ø> (ø)
Files with missing lines Coverage Δ
core/binary_protocol/src/consensus/header.rs 81.87% <100.00%> (+0.30%) ⬆️
core/binary_protocol/src/consensus/operation.rs 97.54% <100.00%> (+0.06%) ⬆️
core/server/src/partition_reconciler.rs 97.90% <100.00%> (+0.06%) ⬆️
core/shard/src/metrics.rs 86.55% <ø> (ø)
core/shard/src/router.rs 81.49% <84.21%> (+7.92%) ⬆️
core/server_common/src/consensus_message.rs 82.70% <90.00%> (+1.40%) ⬆️

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread core/binary_protocol/src/consensus/header.rs
Comment thread core/server_common/src/consensus_message.rs
Comment thread core/shard/src/router.rs Outdated
Comment thread core/shard/src/metrics.rs Outdated
Comment thread core/binary_protocol/src/consensus/header.rs
Comment thread core/shard/src/router.rs Outdated
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Aug 21, 2026
@numinnex
numinnex force-pushed the fix_version_fencing branch from 2eb50e4 to 875f199 Compare August 22, 2026 14:56
@numinnex

Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Aug 22, 2026
hubcio
hubcio previously approved these changes Aug 24, 2026
Comment thread core/server_common/src/consensus_message.rs Outdated
Comment thread core/shard/src/router.rs Outdated
Comment thread core/server/src/partition_reconciler.rs Outdated
Comment thread core/shard/src/router.rs
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Aug 24, 2026
@numinnex

Copy link
Copy Markdown
Contributor Author

/ready

@github-actions github-actions Bot added S-waiting-on-review PR is waiting on a reviewer and removed S-waiting-on-author PR is waiting on author response labels Aug 24, 2026
@hubcio
hubcio merged commit 2bd9d0b into master Aug 24, 2026
99 checks passed
@hubcio
hubcio deleted the fix_version_fencing branch August 24, 2026 19:33
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants