Flink: Fix read split table properties being ignored - #17445
Open
vishnuprakaz wants to merge 2 commits into
Open
Flink: Fix read split table properties being ignored#17445vishnuprakaz wants to merge 2 commits into
vishnuprakaz wants to merge 2 commits into
Conversation
uros-b
reviewed
Aug 2, 2026
| conf = new FlinkReadConf(table, ImmutableMap.of(), new Configuration()); | ||
| assertThat(conf.splitFileOpenCost()).isEqualTo(TableProperties.SPLIT_OPEN_FILE_COST_DEFAULT); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The new test exercises only three of the four precedence tiers (flinkConf > tableProperty > default) for each split option; the top tier; an explicit entry in the readOptions map (the second FlinkReadConf constructor argument) is never asserted. All three tests pass ImmutableMap.of() as the readOptions arg, so the test suite would pass even if the read-option tier were completely broken. Add a fourth assertion per method: instantiate with e.g. ImmutableMap.of(FlinkReadOptions.SPLIT_SIZE, "999") and assert the result beats both the flinkConf value and the table property.
Contributor
Author
|
Thanks for the review @uros-b .Added assertions for the read options tier in all three tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
read.split.target-size,read.split.planning-lookback, orread.split.open-file-costas a table property has no effect on Flink reads. The split options inFlinkReadOptionsdeclare default values, soFlinkConfParseralways returns the Flink default and never reaches the table property fallback inFlinkReadConf, even though the docs promise read option, then Flink configuration, then table property. This is a regression from #5967, which introduced the read options with declared defaults; before that the planner only set the split scan options when explicitly configured and the table properties were honored.The split options now declare no default, like the write options, and the defaults are applied in
FlinkReadConfafter the table property lookup. Needs a backport to 1.20 and 2.0