Aliyun: Remove leaked transitive dependencies#15858
Aliyun: Remove leaked transitive dependencies#15858RussellSpitzer merged 1 commit intoapache:mainfrom
Conversation
singhpk234
left a comment
There was a problem hiding this comment.
LGTM, thanks @rdblue !
|
Missed that the checks hadn't finished since I'm on my phone. But I'm sure we will be fine here, I will revert if they fail |
|
@rdblue, I see could this be a problem/regression at runtime? |
|
libs.aliyun.sdk.oss was already compile only, So we had this weird condition where where a user could have manually included the SDK but not credentials-java and it would have worked if RRSA was on. Technically this would be a regression but we were wrong to do it before and folks were probably not doing the right thing if they relied on it. |
|
It also won't be a regression because this has not been released. We do not include dependencies like this in the runtime libraries and it is not Iceberg's responsibility to ensure everything is on the classpath. |
good point! It now throws which is a reasonable error message Thanks! |
While reviewing dependency changes to the Spark runtime bundle in #15655, we discovered that the Aliyun module was leaking several dependencies as well, including
okioand the Kotlin stdlib:This was introduced in e93eaab3. This PR changes the dependencies to
compileOnlyto exclude them from inclusion in runtime Jars.