Core: Fix Internal to Generic conversion of TIMESTAMP_NANO#15099
Merged
pvary merged 1 commit intoapache:mainfrom Jan 28, 2026
Merged
Core: Fix Internal to Generic conversion of TIMESTAMP_NANO#15099pvary merged 1 commit intoapache:mainfrom
pvary merged 1 commit intoapache:mainfrom
Conversation
nandorKollar
approved these changes
Jan 21, 2026
ayushtkn
changed the title
Member
Author
|
@pvary can u help review |
pvary
reviewed
Jan 28, 2026
| } | ||
|
|
||
| @Test | ||
| public void testTimestampNanoMaterializedAsJavaTime() { |
Contributor
There was a problem hiding this comment.
Could we add this to a new TestGenericDataUtil class, and add tests for the other conversions?
pvary
approved these changes
Jan 28, 2026
Contributor
|
Merged to main. |
Member
Author
|
Thanx @pvary and @nandorKollar for the review & merge :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15098