Spec: Change UUID fields from string type to UUIDTypeValue#15095
Spec: Change UUID fields from string type to UUIDTypeValue#15095rambleraptor wants to merge 1 commit intoapache:mainfrom
Conversation
| maximum: 3 | ||
| table-uuid: | ||
| type: string | ||
| $ref: '#/components/schemas/UUIDTypeValue' |
There was a problem hiding this comment.
for other reviewers: this shouldn't break any spec guarantees because UUIDTypeValue is defined to be string in
iceberg/open-api/rest-catalog-open-api.yaml
Lines 4290 to 4295 in bf54961
There was a problem hiding this comment.
LGTM too, thanks @rambleraptor !
should we raise a quick dev thread for awareness, in case there are outliers ?
|
I made a post at https://lists.apache.org/thread/n4nov1kksryvtb176rnmmw259pv8d9pt |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
I noticed that we have several UUID fields in the REST Catalog that are just basic strings. Moving them over to UUIDTypeValue shows the proper validation + proper context, especially to OpenAPI tools that are consuming the spec.
This change should be a no-op, since these UUID restrictions already existed, but were never documented.