Skip to content

Spec: Change UUID fields from string type to UUIDTypeValue#15095

Closed
rambleraptor wants to merge 1 commit intoapache:mainfrom
rambleraptor:uuid_rest_catalog2
Closed

Spec: Change UUID fields from string type to UUIDTypeValue#15095
rambleraptor wants to merge 1 commit intoapache:mainfrom
rambleraptor:uuid_rest_catalog2

Conversation

@rambleraptor
Copy link
Contributor

I noticed that we have several UUID fields in the REST Catalog that are just basic strings. Moving them over to UUIDTypeValue shows the proper validation + proper context, especially to OpenAPI tools that are consuming the spec.

This change should be a no-op, since these UUID restrictions already existed, but were never documented.

@manuzhang manuzhang changed the title Change UUID fields from string type to UUIDTypeValue Spec: Change UUID fields from string type to UUIDTypeValue Jan 21, 2026
maximum: 3
table-uuid:
type: string
$ref: '#/components/schemas/UUIDTypeValue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for other reviewers: this shouldn't break any spec guarantees because UUIDTypeValue is defined to be string in

UUIDTypeValue:
type: string
format: uuid
pattern: '^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$'
maxLength: 36
minLength: 36

Copy link
Contributor

@singhpk234 singhpk234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks @rambleraptor !

should we raise a quick dev thread for awareness, in case there are outliers ?

@rambleraptor
Copy link
Contributor Author

I made a post at https://lists.apache.org/thread/n4nov1kksryvtb176rnmmw259pv8d9pt

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 5, 2026
@github-actions
Copy link

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants