feat: add middleware support to REST catalog client#1971
Open
rohankmr414 wants to merge 7 commits intoapache:mainfrom
Open
feat: add middleware support to REST catalog client#1971rohankmr414 wants to merge 7 commits intoapache:mainfrom
rohankmr414 wants to merge 7 commits intoapache:mainfrom
Conversation
Introduces an optional `middleware` feature to enable custom HTTP middleware for the REST catalog client. This integration with `reqwest-middleware` allows users to inject custom logic into HTTP requests, facilitating advanced functionalities such as logging, retry mechanisms, rate limiting, and custom authentication. A `with_middleware_client` method is added to `RestCatalogBuilder` for easy configuration.
Reorders import statements within a middleware test for better consistency and readability.
Author
|
This change is required to support authentication headers in scenarios such as projected Kubernetes service account tokens. These tokens are rotated frequently (typically every hour), so it’s important for clients to be able to watch the token file and update the headers dynamically as the token changes. This middleware support will enable such use cases seamlessly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for HTTP middleware in the
iceberg-catalog-restcrate, allowing users to inject custom middleware (such as logging, retries, or authentication) into HTTP requests using thereqwest-middlewarecrate. The implementation is feature-gated and includes documentation, configuration options, and tests for middleware support.Middleware support:
middlewarefeature toCargo.tomlthat enables integration with thereqwest-middlewarecrate for custom HTTP middleware capabilities. [1] [2]RestCatalogBuilderandRestCatalogConfigstructs to support amiddleware_clientfield, and provided awith_middleware_clientmethod for configuration. [1] [2] [3]HttpClientto use the middleware client when configured, including logic in theexecutemethod to route requests through middleware if present. [1] [2] [3] [4]Documentation:
README.mdwith usage instructions and examples for enabling and using middleware support.Testing: