Core: Deprecate 'downcast-ns-timestamp-to-us-on-write' config key#3596
Open
qzyu999 wants to merge 1 commit into
Open
Core: Deprecate 'downcast-ns-timestamp-to-us-on-write' config key#3596qzyu999 wants to merge 1 commit into
qzyu999 wants to merge 1 commit into
Conversation
…of 'downcast-ns-timestamp-to-us' The config key 'downcast-ns-timestamp-to-us-on-write' says 'on-write' but is also used in the read path (ArrowScan). Rename the canonical key to 'downcast-ns-timestamp-to-us' which accurately describes the behavior regardless of direction. The old key still works but emits a DeprecationWarning. The new key takes precedence when both are set.
qzyu999
force-pushed
the
deprecate-downcast-on-write-config-key
branch
from
59ade22 to
c887117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Minor config naming issue raised in #3594 (review)
Rationale for this change
The config key
downcast-ns-timestamp-to-us-on-write(env:PYICEBERG_DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE) says 'on-write' but is also used in the read path (ArrowScan) to downcast nanosecond timestamps to microseconds. The name is misleading.What changes are included in this PR?
downcast-ns-timestamp-to-us(env:PYICEBERG_DOWNCAST_NS_TIMESTAMP_TO_US)_get_downcast_ns_timestamp_to_us()helper that checks the new key first, falls back to the old key with aDeprecationWarning\Are there any user-facing changes?
downcast-ns-timestamp-to-us/PYICEBERG_DOWNCAST_NS_TIMESTAMP_TO_US\DeprecationWarning\