Open
Conversation
geruh
reviewed
Feb 1, 2026
| notebook: notebook-install ## Launch notebook for experimentation | ||
| uv run jupyter lab --notebook-dir=notebooks | ||
| notebook: ## Launch notebook for experimentation | ||
| uv run $(PYTHON_ARG) --all-extras --group notebook jupyter lab --notebook-dir=notebooks |
| docs-serve docs-build notebook notebook-infra \ | ||
| clean uv-lock uv-lock-check | ||
|
|
||
| .DEFAULT_GOAL := help |
Contributor
There was a problem hiding this comment.
nit: non blocking but add a space after this
| uses: astral-sh/setup-uv@v7 | ||
| - name: Install | ||
| run: make docs-install | ||
| - name: Build docs |
Contributor
There was a problem hiding this comment.
Now install is included with build step
|
|
||
| docs-build: ## Build the static documentation site | ||
| uv run $(PYTHON_ARG) mkdocs build -f mkdocs/mkdocs.yml --strict | ||
| uv run $(PYTHON_ARG) --group docs mkdocs build -f mkdocs/mkdocs.yml --strict |
Contributor
There was a problem hiding this comment.
the docs group are in the projects default group here:
Lines 142 to 146 in c0e7c6d
Seems like we can lighten up the base for install!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
uv run --groupto auto-install dependencies on demand, eliminating the need for separate install targets. Dependencies are automatically installed on first use.PHONYdeclarations - Prevents issues if files with target names exist.DEFAULT_GOAL := help- Runningmakewithout arguments now shows the help messageAre these changes tested?
Are there any user-facing changes?