Skip to content

ci: split S3/MinIO into a Linux and macOS-only workflow#642

Merged
wgtmac merged 1 commit intoapache:mainfrom
zhjwpku:ci/dedicated-s3-workflow
May 6, 2026
Merged

ci: split S3/MinIO into a Linux and macOS-only workflow#642
wgtmac merged 1 commit intoapache:mainfrom
zhjwpku:ci/dedicated-s3-workflow

Conversation

@zhjwpku
Copy link
Copy Markdown
Collaborator

@zhjwpku zhjwpku commented May 6, 2026

Closes #640

@zhjwpku zhjwpku force-pushed the ci/dedicated-s3-workflow branch from 6f406c6 to a600ef7 Compare May 6, 2026 08:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI failures on Windows runners caused by the lack of a Windows-compatible minio/minio Docker image by decoupling S3/MinIO-backed testing from the main cross-platform workflow and running it only on Linux/macOS.

Changes:

  • Made S3 support in the CI build script configurable (defaulting to OFF) so non-S3 workflows don’t build/run S3 tests.
  • Removed MinIO startup and S3 environment variables from the main test.yml workflow (including Windows).
  • Added a dedicated s3_test.yml workflow that runs MinIO-backed S3 tests on Ubuntu and macOS only.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ci/scripts/build_iceberg.sh Adds an explicit ICEBERG_S3 ON/OFF switch via a new positional argument so CI can disable S3 where unsupported.
.github/workflows/test.yml Removes MinIO/S3 env and startup from the main test workflow to avoid Windows Docker manifest issues.
.github/workflows/s3_test.yml Introduces a separate Linux/macOS workflow to run S3 integration tests against MinIO.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wgtmac
Copy link
Copy Markdown
Member

wgtmac commented May 6, 2026

Currently the new split workflows still do the same thing. In the future we may use a dedicated script to build and run components relevant to AWS only.

@wgtmac wgtmac merged commit db7bb30 into apache:main May 6, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DISCUSSION] Docker MinIO image not available for Windows platform

3 participants