feat: Implement OAuth2 authentication for REST catalog#577
Open
lishuxu wants to merge 3 commits intoapache:mainfrom
Open
feat: Implement OAuth2 authentication for REST catalog#577lishuxu wants to merge 3 commits intoapache:mainfrom
lishuxu wants to merge 3 commits intoapache:mainfrom
Conversation
wgtmac
reviewed
Mar 6, 2026
Member
wgtmac
left a comment
There was a problem hiding this comment.
This is a comprehensive code review report generated by gemini-cli against PR #577. The review rigorously compares the C++ implementation with the RFC 6749 (OAuth2) spec and the current Iceberg Java behavior.
Overall, the structure and C++ style are excellent, but there are a few parity and robustness issues that need addressing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OAuth2 authentication support for the REST catalog, including:
Also includes:
headers properly override defaults
TODO:
RefreshToken and ExchangeToken will be supported later