Skip to content

feat: Implement OAuth2 authentication for REST catalog#577

Open
lishuxu wants to merge 3 commits intoapache:mainfrom
lishuxu:feature/oauth
Open

feat: Implement OAuth2 authentication for REST catalog#577
lishuxu wants to merge 3 commits intoapache:mainfrom
lishuxu:feature/oauth

Conversation

@lishuxu
Copy link
Contributor

@lishuxu lishuxu commented Feb 26, 2026

Add OAuth2 authentication support for the REST catalog, including:

  • OAuth2AuthManager with static token and client_credentials grant flows

Also includes:

  • Fix BuildHeaders in http_client.cc to use insert_or_assign so request-specific
    headers properly override defaults

TODO:
RefreshToken and ExchangeToken will be supported later

Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a comprehensive code review report generated by gemini-cli against PR #577. The review rigorously compares the C++ implementation with the RFC 6749 (OAuth2) spec and the current Iceberg Java behavior.

Overall, the structure and C++ style are excellent, but there are a few parity and robustness issues that need addressing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants