feat: bind literals with right type after serde#562
Merged
wgtmac merged 2 commits intoapache:mainfrom Mar 18, 2026
Merged
Conversation
evindj
force-pushed
the
bound_expressions
branch
from
068a0d1 to
d8e2630
Compare
evindj
force-pushed
the
bound_expressions
branch
4 times, most recently
from
695120b to
e1439d8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wgtmac
requested changes
Mar 13, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for updating this PR! I've added some comments from my initial review.
evindj
force-pushed
the
bound_expressions
branch
2 times, most recently
from
2bbb95f to
ae4e144
Compare
evindj
force-pushed
the
bound_expressions
branch
from
ae4e144 to
761c03c
Compare
wgtmac
approved these changes
Mar 18, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for the update! I've pushed a comment to address issues identified by another round of review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expressions serde will convert some types to string but right now, the binding process does not support translating from the string representation back to the right type this PR addresses this gap.
This PR must be landed after #553 is merged.