Fix URIBuilder encoding policy documentation and null reset - #696
Merged
Conversation
Member
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URIBuilder defaults to ALL_RESERVED, but setEncodingPolicy's Javadoc incorrectly identifies RFC_3986 as the default. Passing null also selects RFC_3986 behavior instead of restoring the documented default.
This change corrects the Javadoc and makes null restore ALL_RESERVED.
Incorrect doc -
httpcomponents-core/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
Lines 206 to 216 in 4021b98
Current Default -
httpcomponents-core/httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java
Line 91 in 4021b98
Validation: ./mvnw -pl httpcore5 verify passed. All 1,380 tests passed, with no failures, errors, or skips.