HIVE-29565: Add DB configs to HS2 docker-compose to enable Hive compaction#6430
HIVE-29565: Add DB configs to HS2 docker-compose to enable Hive compaction#6430deniskuzZ wants to merge 1 commit intoapache:masterfrom
Conversation
|
|
@deniskuzZ: I tested this with docker llap + compaction: unfortunately, the full successful testing is blocked on HIVE-29566, but at least I reached the
this is confusing, can you confirm if this is by design? does this mean that on hive clusters, the backend RDBMS configs have to be replicated HS2 in order to run query-based compaction?
I'm fine with 1) if at least a comment in docker compose file can emphasize that HS2 really needs postgres connection configs (for CRUD compaction), otherwise, we cannot guarantee that confusing folks in the future (like me now :) ) won't remove this config if we can agree on / clarify this, the patch is +1 from my side, as fixing/supporting compaction is a great improvement for our wonderful docker-based testing |



What changes were proposed in this pull request?
Add missing DB configs to HS2
Why are the changes needed?
HS2 uses a direct connection to backend DB for Compaction
Does this PR introduce any user-facing change?
No
How was this patch tested?
docker-compose + beeline with compaction sql