HIVE-29403: Move the truncate table out of HMSHandler#6269
HIVE-29403: Move the truncate table out of HMSHandler#6269dengzhhu653 merged 6 commits intoapache:masterfrom
Conversation
dengzhhu653
force-pushed
the
HIVE-29403
branch
from
b5a0a89 to
bf64176
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
dengzhhu653
force-pushed
the
HIVE-29403
branch
from
bf64176 to
e305e22
Compare
|
cc @wecharyu @saihemanth-cloudera could you take a look if have secs? thank you! |
dengzhhu653
force-pushed
the
HIVE-29403
branch
from
e305e22 to
0daab9d
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
labels
...tastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/JavaUtils.java
Outdated
Show resolved
Hide resolved
...re-server/src/main/java/org/apache/hadoop/hive/metastore/handler/AbstractRequestHandler.java
Outdated
Show resolved
Hide resolved
| Class<? extends TBase> requestBody(); | ||
| boolean supportAsync() default false; | ||
| String id() default "getId"; | ||
| String cancel() default "isCancel"; |
There was a problem hiding this comment.
id and cancel is from request, it seems a little strange to set get such annotations for handler.
There was a problem hiding this comment.
when creating the handler, it knows what the request is, and how to get the async id from the request at the definition.
...re-server/src/main/java/org/apache/hadoop/hive/metastore/handler/AbstractRequestHandler.java
Show resolved
Hide resolved
...store-server/src/main/java/org/apache/hadoop/hive/metastore/handler/DropDatabaseHandler.java
Show resolved
Hide resolved
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/handler/DropTableHandler.java
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
tests unstable
labels
|
wecharyu
left a comment
wecharyu
left a comment
There was a problem hiding this comment.
LGTM, left a minor comment.
| } | ||
| } | ||
|
|
||
| private boolean updateTableColumnStatsInternal(ColumnStatistics colStats, |
There was a problem hiding this comment.
Try to reuse HMSHandler#updateTableColumnStatsInternal .
There was a problem hiding this comment.
Thanks for the comments.
The reason is it's not easy to make it as a static method, I'm agree with the reuse, filed HIVE-29407 to follow with the optimization
...store-server/src/main/java/org/apache/hadoop/hive/metastore/handler/DropDatabaseHandler.java
Show resolved
Hide resolved
| <name>Hive Metastore Server</name> | ||
| <properties> | ||
| <standalone.metastore.path.to.root>..</standalone.metastore.path.to.root> | ||
| <reflections.version>0.10.2</reflections.version> |
There was a problem hiding this comment.
nit: this could be moved to standalone-metstore/pom.xml
There was a problem hiding this comment.
will address it in the follow-ups
|
Thank you @wecharyu, @saihemanth-cloudera for the review! |
4 participants
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?