HBASE-30054 Avoid cascading delete for failed backups - #8562
Open
Sigma-Ma wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30054
What changes were proposed in this pull request?
This patch prevents non-complete backup sessions from participating in cascading backup deletion.
BackupAdminImpl#getAffectedBackupSessionsnow returns no affected sessions unless the backup being deleted is in theCOMPLETEstate.TestIncrementalBackupWithFailureswas extended to create a successful incremental backup after failed incremental backup attempts, delete one of the failed backups, and verify that the successful backup remains complete with its table list intact.Why are the changes needed?
A failed backup is not part of the committed backup chain because the backup system table is restored before the
FAILEDbackup record is written.However, deleting a failed backup currently runs the same affected-session calculation used for completed backups. As a result, newer successful incremental backups can be treated as dependent backups and have their metadata or backup image removed.
Only completed backups can have later backups depending on them. Skipping the cascading calculation for non-complete backups allows the failed backup itself to be cleaned up without affecting later valid backups.
How was this patch tested?
mvn -pl hbase-backup -am \ -Dtest=TestIncrementalBackupWithFailures \ -Dsurefire.failIfNoSpecifiedTests=false \ testThe test covers a completed full backup, failed incremental backup attempts, a later completed incremental backup, and deletion of a failed backup. It verifies that the failed backup record is removed and that the later completed backup remains available with both tables.