HBASE-30095 Remove duplicate MiniDFSCluster startup in TestZooKeeper - #8556
Open
Sigma-Ma wants to merge 1 commit into
Open
HBASE-30095 Remove duplicate MiniDFSCluster startup in TestZooKeeper#8556Sigma-Ma wants to merge 1 commit into
Sigma-Ma wants to merge 1 commit into
Conversation
Contributor
|
This was intentionally added by @saintstack here 7df9490. Although I didn't get it, he can help us here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30095
What changes were proposed in this pull request?
Remove the duplicate
TEST_UTIL.startMiniDFSCluster(2)call fromTestZooKeeper#setUpBeforeClass.The first MiniDFSCluster startup is retained, preserving the intended test initialization sequence: start MiniDFSCluster, start MiniZooKeeper, configure the test environment, and then start MiniHBaseCluster for each test.
Why are the changes needed?
HBaseTestingUtilshould manage only one MiniDFSCluster at a time. CallingstartMiniDFSClustertwice replaces the storeddfsClusteranddfsClusterFixerreferences without shutting down the first cluster.This can leave the first cluster running against the same test directories and cause HDFS namespace conflicts, including
InconsistentFSStateException, in CI runs.How was this patch tested?
mvn -pl hbase-server -am -Dtest=TestZooKeeper -Dsurefire.rerunFailingTestsCount=0 test