Skip to content

GROOVY-6526: annotations: compute allowed targets lazily#2388

Merged
eric-milles merged 3 commits intomasterfrom
GROOVY-6526
Mar 7, 2026
Merged

GROOVY-6526: annotations: compute allowed targets lazily#2388
eric-milles merged 3 commits intomasterfrom
GROOVY-6526

Conversation

@eric-milles
Copy link
Member

Move target checking from vmplugin to ast node. Only compute once per annotation type.

If this is okay, retention policy will follow.

@eric-milles eric-milles requested a review from paulk-asert March 5, 2026 15:37
@asf-gitbox-commits asf-gitbox-commits force-pushed the GROOVY-6526 branch 3 times, most recently from 7f34842 to c07e93d Compare March 5, 2026 23:29
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 74.24242% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.1254%. Comparing base (7d8349c) to head (b589d83).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...n/java/org/codehaus/groovy/ast/AnnotationNode.java 73.5849% 9 Missing and 5 partials ⚠️
...org/codehaus/groovy/classgen/ExtendedVerifier.java 25.0000% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2388        +/-   ##
==================================================
+ Coverage     66.7571%   67.1254%   +0.3683%     
- Complexity      29856      30949      +1093     
==================================================
  Files            1382       1382                
  Lines          116130     117416      +1286     
  Branches        20471      21226       +755     
==================================================
+ Hits            77525      78816      +1291     
- Misses          32275      32291        +16     
+ Partials         6330       6309        -21     
Files with missing lines Coverage Δ
...rg/codehaus/groovy/ast/decompiled/Annotations.java 89.8551% <ø> (-0.1449%) ⬇️
...in/java/org/codehaus/groovy/vmplugin/VMPlugin.java 12.5000% <100.0000%> (+5.8333%) ⬆️
.../java/org/codehaus/groovy/vmplugin/v16/Java16.java 56.0000% <ø> (-3.2593%) ⬇️
...in/java/org/codehaus/groovy/vmplugin/v8/Java8.java 76.0135% <100.0000%> (-1.6991%) ⬇️
...in/java/org/codehaus/groovy/vmplugin/v9/Java9.java 59.7222% <ø> (-0.5517%) ⬇️
...tracts/ast/visitor/AnnotationProcessorVisitor.java 89.0909% <ø> (-0.1948%) ⬇️
...org/codehaus/groovy/classgen/ExtendedVerifier.java 94.9367% <25.0000%> (+3.0339%) ⬆️
...n/java/org/codehaus/groovy/ast/AnnotationNode.java 69.9029% <73.5849%> (-1.9281%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eric-milles eric-milles merged commit e16c9fb into master Mar 7, 2026
42 of 43 checks passed
@eric-milles eric-milles deleted the GROOVY-6526 branch March 13, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants