GROOVY-11859: fix JarJarTask annotation for Windows compatibility#2380
Merged
paulk-asert merged 1 commit intoapache:masterfrom Feb 23, 2026
Merged
GROOVY-11859: fix JarJarTask annotation for Windows compatibility#2380paulk-asert merged 1 commit intoapache:masterfrom
paulk-asert merged 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes GROOVY-11859 by correcting Gradle task input annotations in JarJarTask so Windows builds don’t fail when untouchedFiles contains glob patterns rather than real file paths.
Changes:
- Replaces
@InputFiles @ClasspathonuntouchedFileswith@Inputto treat the value as plain strings for up-to-date checking/caching.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2380 +/- ##
==================================================
+ Coverage 66.7154% 66.7172% +0.0017%
- Complexity 29846 29848 +2
==================================================
Files 1382 1382
Lines 116180 116180
Branches 20491 20491
==================================================
+ Hits 77510 77512 +2
Misses 32323 32323
+ Partials 6347 6345 -2 🚀 New features to boost your workflow:
|
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/GROOVY-11859
JarJarTask.untouchedFilesis aList<String>of glob patterns (e.g.CliBuilder*), not file paths. The@InputFiles @Classpathannotations cause Gradle to resolve these patterns as literal file paths on Windows, failing the build. Changed to@Inputsince these are plain string values.