[NOT FOR MERGE] experiment with making deserialize check the type#2398
Open
pjfanning wants to merge 4 commits intoapache:mainfrom
Open
[NOT FOR MERGE] experiment with making deserialize check the type#2398pjfanning wants to merge 4 commits intoapache:mainfrom
pjfanning wants to merge 4 commits intoapache:mainfrom
Conversation
Member
pjfanning
commented
Jul 8, 2025
- Experiment related to [Java] add more defensive version of deserialize(byte, class) #2391
- very unlikely to ever get merged but I would like to support users who carefully write their classes to make them strongly typed minimising the risks with deserialization attacks - with strongly typed classes and us checking that the input bytes match the expected type means that in theory those careful users wouldn't need to go through the tedium of writing class checkers or registering all the classes they need
- this version is still naive and is possibly at risk at having an attacker hide a dangerous class instance nested inside the main class - I will add structured test classes to test this out
- so far, the implementation changes are small and do not add much overhead because the ClassInfo is already looked up when I do the checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.