[common] Optimize getNullCounts() to return int[] instead of Long[]#3054
Open
platinumhamburg wants to merge 1 commit intoapache:mainfrom
Open
[common] Optimize getNullCounts() to return int[] instead of Long[]#3054platinumhamburg wants to merge 1 commit intoapache:mainfrom
platinumhamburg wants to merge 1 commit intoapache:mainfrom
Conversation
Since null counts are stored as 4-byte integers in the batch statistics binary format, int[] is sufficient and avoids boxing overhead (8 bytes per Long vs 4 bytes per int). Use -1 as the sentinel for "not available" instead of null. This reduces memory usage for cachedNullCounts and statsNullCounts, especially for wide tables with many fields. Closes apache#3021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since null counts are stored as 4-byte integers in the batch statistics binary format, int[] is sufficient and avoids boxing overhead (8 bytes per Long vs 4 bytes per int). Use -1 as the sentinel for "not available" instead of null. This reduces memory usage for cachedNullCounts and statsNullCounts, especially for wide tables with many fields.
Closes #3021
Purpose
Linked issue: close #3021
Brief change log
Tests
API and Format
Documentation