[FLINK-40637][table] Expand catalog views hermetically against the view's own database - #29165
Open
talatuyarer wants to merge 1 commit into
Open
[FLINK-40637][table] Expand catalog views hermetically against the view's own database#29165talatuyarer wants to merge 1 commit into
talatuyarer wants to merge 1 commit into
Conversation
…iers in table resolution
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
CatalogView's expanded query contains unqualified table references, the planner resolved them against the reader's current session database instead of the view's own catalog/database. The same view could then succeed in one session and fail in another. This is observable with external catalogs (e.g. Iceberg) that return portable, unqualified SQL fromCatalogView#getExpandedQuery().Root cause:
CatalogManager.resolveCatalogVieweagerly parses the expanded query withparser.parse(...)in the session context (introduced in FLINK-37098), which qualifies unqualified references against the current session database and bypasses the hermetic view-expansion path.