Skip to content

[FLINK-40633][s3] Allow overriding the Maven executable in download-crt-jars.sh #29162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaborgsomogyi wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −5
Open

[FLINK-40633][s3] Allow overriding the Maven executable in download-crt-jars.sh #29162

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions flink-filesystems/flink-s3-fs-native/tools/download-crt-jars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,20 @@
# Environment:
# AWS_CRT_VERSION Override the auto-resolved aws-crt version (rarely
# needed; use only when the auto-resolver fails).
# MVN Maven executable to invoke. Defaults to "mvn".
#
# Requirements: mvn (Apache Maven) on PATH.
# Requirements: mvn (Apache Maven) on PATH, or MVN set to a Maven executable.

set -euo pipefail

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
MODULE_DIR="$(cd "${SCRIPT_DIR}/.." && pwd)"
POM_FILE="${MODULE_DIR}/pom.xml"
OUTPUT_DIR="${1:-${MODULE_DIR}/crt-jars}"
MVN=${MVN:-mvn}

if ! command -v mvn >/dev/null 2>&1; then
echo "ERROR: mvn (Apache Maven) is required but not on PATH." >&2
if ! command -v "${MVN}" >/dev/null 2>&1; then
echo "ERROR: Maven executable '${MVN}' is required but not on PATH." >&2
exit 1
fi

Expand Down Expand Up @@ -95,7 +97,7 @@ resolve_crt_version() {
</dependencies>
</project>
EOF
mvn -q -f "${tmp_pom}" dependency:list \
"${MVN}" -q -f "${tmp_pom}" dependency:list \
-DincludeGroupIds=software.amazon.awssdk.crt \
-DincludeArtifactIds=aws-crt \
-DexcludeTransitive=false \
Expand All @@ -116,7 +118,7 @@ mkdir -p "${OUTPUT_DIR}"

echo "Downloading aws-crt:${CRT_VERSION} into ${OUTPUT_DIR}"

mvn -q dependency:copy \
"${MVN}" -q dependency:copy \
-Dartifact="software.amazon.awssdk.crt:aws-crt:${CRT_VERSION}:jar" \
-DoutputDirectory="${OUTPUT_DIR}" \
-Dmdep.stripVersion=false
Expand Down