Skip to content

[FLINK-37837][core] Always add create.table to include.schema.changes option#4262

Open
Hisoka-X wants to merge 1 commit intoapache:masterfrom
Hisoka-X:FLINK-37837-schema-change-option
Open

[FLINK-37837][core] Always add create.table to include.schema.changes option#4262
Hisoka-X wants to merge 1 commit intoapache:masterfrom
Hisoka-X:FLINK-37837-schema-change-option

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Feb 5, 2026

This close https://issues.apache.org/jira/browse/FLINK-37837

This pull request ensures that the CreateTableEvent is always included in the set of schema change events unless the user explicitly excludes it. This change guarantees the foundational event is present for proper schema evolution handling.

@github-actions github-actions bot added the cli label Feb 5, 2026
@Hisoka-X Hisoka-X closed this Feb 9, 2026
@Hisoka-X Hisoka-X reopened this Feb 9, 2026
@ThorneANN
Copy link
Contributor

Thank you for your contribution and i left some comment

@ThorneANN
Copy link
Contributor

I think that always add create.table to include.schema.changes option is not a good idea ,because user can create table without flink-cdc and others

@Hisoka-X
Copy link
Member Author

I think that always add create.table to include.schema.changes option is not a good idea ,because user can create table without flink-cdc and others

Users can set create.table into exclude.schema.changes.

@ThorneANN
Copy link
Contributor

and i think the jira's error was

I think that always add create.table to include.schema.changes option is not a good idea ,because user can create table without flink-cdc and others

Users can set create.table into exclude.schema.changes.

I think this is the correct processing logic, if users always create tables first, and creating tables may be a failure that leads to task failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants