FINERACT-2515: Fix the TODO comments in the Apache Fineract Code#5672
Open
KRYSTALM7 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-2515: Fix the TODO comments in the Apache Fineract Code#5672KRYSTALM7 wants to merge 1 commit intoapache:developfrom
KRYSTALM7 wants to merge 1 commit intoapache:developfrom
Conversation
Author
|
This PR removes three Happy to address any feedback! |
Contributor
|
@KRYSTALM7 Please configure proper GPG signature for your commits. |
…an domain classes
KRYSTALM7
force-pushed
the
FINERACT-2515-remove-auto-generated-todo-comments
branch
from
dae1587 to
f7c9d20
Compare
Author
|
Hi @adamsaghy, thank you for the feedback! I have configured GPG signing for my commits and force-pushed both PRs. Happy to address any other feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes stale auto-generated TODO stub comments from three classes
in the fineract-loan module as part of the ongoing effort to reduce
technical debt (FINERACT-2515).
Changes
LoanInstallmentCharge.java: Removed
// TODO Auto-generated constructor stubfrom the default no-arg constructor. Theconstructor body is intentionally empty and the comment adds
no value.
LoanTransaction.java: Removed
// TODO Auto-generated method stubfrom theupdateAmount()method. The implementation iscomplete and the comment is misleading.
DuplicateGuarantorException.java: Removed
// TODO Auto-generated constructor stubfrom the parameterizedconstructor. The
super()call is properly implemented.Testing
No functional changes — comments only. Existing tests cover
all modified classes.
Checklist