FINERACT-1659: Fix optimistic locking in savings interest posting batch job

[awaneetdecoder]

Problem

The savings interest posting batch job could post duplicate interest
when two instances ran concurrently. PR #5550 attempted a fix but
adamsaghy correctly identified there was no rollback mechanism —
version mismatch was silently skipped.

Fix

• SQL uses WHERE id=? AND version=? to detect concurrent modification
• version = version + 1 increments on each successful update
• updateCounts[i] == 0 detected as concurrent modification
• ConcurrentModificationException thrown on version mismatch
• @transactional on postInterest() rolls back entire batch

Files Changed

• SavingsAccountData.java — added version field
• SavingsAccountReadPlatformServiceImpl.java — reads version from DB
• SavingsSchedularInterestPoster.java — core fix
• SavingsSchedularInterestPosterTest.java — unit tests
• SavingsInterestPostingJobIntegrationTest.java — integration tests

Fixes FINERACT-1659
Supersedes PR #5550

[awaneetdecoder]

I have force-pushed the fixes for the Lombok duplicate getters/setters and the Checkstyle trailing space. Could a maintainer please approve the workflows so the CI can run against the new commit? Thank you!

[adamsaghy]

@awaneetdecoder Please review the failing checks!

[adamsaghy]

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

[awaneetdecoder]

@adamsaghy I have addressed all the failing checks:

1. Replaced ConcurrentModificationException with Spring's OptimisticLockingFailureException — this is semantically correct for optimistic locking failures, extends DataAccessException so it is caught by the existing handler in postInterest(), and satisfies SpotBugs.

2. Removed unused mock infrastructure from the unit test — the 4 tests verify pure logic (updateCounts array checking) and have no dependency on Spring beans, so no mocks are needed.

3. Ran both commands locally — spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest and build -x test -x cucumber -x doc both passed cleanly. The :fineract-war:binaryDistTar failure is a pre-existing duplicate JAR issue reproducible on develop with no changes applied.

Thank you for your patience.