Skip to content

FINERACT-GSOC: Modernize UserHelper and RolesHelper with Fineract-Client#5666

Open
Avtansh88 wants to merge 1 commit intoapache:developfrom
Avtansh88:gsoc/modernize-user-helper
Open

FINERACT-GSOC: Modernize UserHelper and RolesHelper with Fineract-Client#5666
Avtansh88 wants to merge 1 commit intoapache:developfrom
Avtansh88:gsoc/modernize-user-helper

Conversation

@Avtansh88
Copy link

@Avtansh88 Avtansh88 commented Mar 21, 2026

## Description

This PR is a Proof of Concept (PoC) for my GSoC 2026 proposal: "Modernizing Integration Tests with Fineract-Client".

Key Changes:

->UserHelper.java: Refactored legacy RestAssured methods to use type-safe Fineract-Client (Feign).

->RolesHelper.java: Introduced a modern, parameter-less createRole() method to resolve inter-helper dependencies and ensure backward compatibility.

->Type Safety: Replaced manual JSON string building with OpenAPI models like PostUsersRequest and PutUsersUserIdRequest.

->Code Cleanup: Removed redundant RequestSpecification and ResponseSpecification from modernized method signatures.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@vidakovic
Copy link
Contributor

vidakovic commented Mar 22, 2026

No proper Jira ticket referenced. Is this a problem we have identified or a spontaneous improvement? In short: no Jira ticket, no PR. Please provide a ticket and format the PR title according to the rules ("FINERACT-1234: Some title here"), thanks.

@Avtansh88
Copy link
Author

Hi @vidakovic, thanks for the guidance.I've already requested a Jira account to create the formal ticket for this improvement. It might take a couple of days for approval. Once it's active, I'll link the ticket here and update the PR title accordingly. In the meantime, I'm also working on modernizing other helpers like RolesHelper to ensure consistency. Thanks for your patience.

@Avtansh88 Avtansh88 force-pushed the gsoc/modernize-user-helper branch from aceb110 to 4b8d017 Compare March 23, 2026 15:24
@Avtansh88 Avtansh88 force-pushed the gsoc/modernize-user-helper branch from 4b8d017 to 09a084a Compare March 23, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants