FINERACT-2436: Fix Client Trends by Week or Month don't work on Postgresql#5342
FINERACT-2436: Fix Client Trends by Week or Month don't work on Postgresql#5342Kengne-yvana wants to merge 0 commit intoapache:developfrom
Conversation
There was a problem hiding this comment.
This change is to make sure FINERACT uses postgresql and MySQL when needed without breaking the code . Having the same author and path but different id. I added database-specific Liquibase contexts to ensure the correct SQL dialect is applied without affecting existing MySQL installations. This fix replaces MySQL-specific functions (WEEK, MONTHNAME) with ISO-standard functions (EXTRACT, TO_CHAR) for PostgreSQL environments, while maintaining the same author and file path for traceability.
galovics
left a comment
There was a problem hiding this comment.
Whats the reason for changing an existing changelog file?
|
@galovics I choose to add the fix to this file because that's where my research let me to which is where the reports where updated for Mysql . |
|
@Kengne-yvana I think that it is better to create a new changelog file. So then the fix will be applied as a new migration. |
|
@IOhacker thanks for your review |
|
@Kengne-yvana I hope you are better now. Please let me know once I can review the PR again :) Thank you |
|
@IOhacker yeah, Hello i am back now . Feeling much better. also i will apply all the changes today. |
22cba44 to
8e16741
Compare
|
@IOhacker please i am waiting for your review |
adamsaghy
left a comment
There was a problem hiding this comment.
Can you please add a test case which tests whether the fixed reports are working as expected?
|
sure @adamsaghy |
8e16741 to
7bb14ed
Compare
|
@Kengne-yvana Kindly asking you to rebase this PR! |
|
@Kengne-yvana you have to resolve the conflicts doing a rebase in your local repository. Make sure to squash and commit for sending only 1 commit. |
|
@IOhacker that's what i am doing now. thanks |
8d2072f to
3ab43e3
Compare
|
@Kengne-yvana Please review the failing checks! |
1fb636f to
623fd58
Compare
|
@Kengne-yvana in the Apache Fineract Dev List, there is a post about the recent changes in the GitHub Actions |
c49ec2d to
9f6a434
Compare
9f6a434 to
ef12056
Compare
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.