Skip to content

Conversation

@diysimon
Copy link
Contributor

@diysimon diysimon commented Feb 4, 2026

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Restore the functionality of the webkit-dep test case by providing the missing webkit-dep.json data file.

Fixed issues

Details

Before: What was the problem?

The test file test/webkit-dep.html was attempting to fetch webkit-dep.json, but this data file was missing from the repository. As a result, the example failed to load any data and could not be displayed or tested.

image

After: How does it behave after the fixing?

Added the required test/data/webkit-dep.json file. Now the webkit-dep.html test case can properly load the graph data and render the dependencies correctly.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

Security Checking

  • This PR uses security-sensitive Web APIs.

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 4, 2026

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only.

@Ovilia Ovilia merged commit 33cf6e7 into apache:master Feb 5, 2026
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Feb 5, 2026

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-21508@a46c535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants