Skip to content

[3.3] Get moduleModel at ReferenceBeanManager#prepareReferenceBeans method to avoid getting null result#15769

Merged
wangchengming666 merged 2 commits intoapache:3.3from
zrlw:3.3-get-moduleModel-at-prepareReferenceBeans
Jan 19, 2026
Merged

[3.3] Get moduleModel at ReferenceBeanManager#prepareReferenceBeans method to avoid getting null result#15769
wangchengming666 merged 2 commits intoapache:3.3from
zrlw:3.3-get-moduleModel-at-prepareReferenceBeans

Conversation

@zrlw
Copy link
Copy Markdown
Contributor

@zrlw zrlw commented Nov 13, 2025

What is the purpose of the change?

try to fix #15663

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.75%. Comparing base (f284fab) to head (e770c62).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15769      +/-   ##
============================================
- Coverage     60.76%   60.75%   -0.01%     
+ Complexity    11712    11695      -17     
============================================
  Files          1938     1938              
  Lines         88646    88646              
  Branches      13379    13379              
============================================
- Hits          53866    53861       -5     
  Misses        29257    29257              
- Partials       5523     5528       +5     
Flag Coverage Δ
integration-tests-java21 32.37% <100.00%> (-0.09%) ⬇️
integration-tests-java8 32.44% <100.00%> (+<0.01%) ⬆️
samples-tests-java21 32.05% <100.00%> (+0.01%) ⬆️
samples-tests-java8 29.70% <100.00%> (+0.10%) ⬆️
unit-tests-java11 59.07% <100.00%> (-0.02%) ⬇️
unit-tests-java17 58.54% <100.00%> (-0.01%) ⬇️
unit-tests-java21 58.56% <100.00%> (-0.01%) ⬇️
unit-tests-java25 58.51% <100.00%> (+<0.01%) ⬆️
unit-tests-java8 59.06% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@RainYuY RainYuY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zrlw zrlw changed the title get moduleModel at ReferenceBeanManager#prepareReferenceBeans method to avoid getting null result [3.3] Get moduleModel at ReferenceBeanManager#prepareReferenceBeans method to avoid getting null result Dec 12, 2025
Copy link
Copy Markdown
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangchengming666 wangchengming666 merged commit 4af95dc into apache:3.3 Jan 19, 2026
33 checks passed
@zrlw zrlw deleted the 3.3-get-moduleModel-at-prepareReferenceBeans branch January 19, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] moduleModel is null after native building

4 participants