-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[fix](iceberg) Preserve nested field case in created schemas #67166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gabriel39
merged 9 commits into
apache:master
from
Gabriel39:fix/preserve-iceberg-nested-field-case
Sep 3, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8136740
fix: preserve nested field case in connector schemas
Gabriel39 1a56c15
[fix](iceberg) Preserve field spelling in complex schema changes
Gabriel39 ab50c4b
[fix](regression) Update Iceberg mixed-case schema expectations
Gabriel39 02f366a
[fix](iceberg) Complete nested field case preservation
Gabriel39 a3845bb
[fix](fe) Complete Iceberg nested field case handling
Gabriel39 d6f98eb
[fix](fe) Preserve legacy struct field lookup
Gabriel39 381f54b
[fix](fe) Resolve nested field runtime identities
Gabriel39 6f1193d
[fix](fe) Canonicalize SQL struct selectors
Gabriel39 458e465
[fix](fe) Complete struct selector resolution
Gabriel39 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Canonicalize the other top-level positioning paths too. This fixes MODIFY by resolving both the target and AFTER sibling to persisted Iceberg spellings, but ADD still routes through
applyPosition, which passesposition.getAfterColumn()verbatim, andreorderColumnsstill passes every caller-provided name directly to the case-sensitivemoveFirst/moveAfterAPIs. On a table with stored fieldsId/Label,ADD ... AFTER idand a reorder usinglabel/idtherefore still fail even though Doris resolves external columns case-insensitively. Please reuse schema-backed canonicalization for ADD and resolve the complete reorder list before staging it, with mixed-case catalog-backed tests.